Errors in TypeScript are being brought up by using if-else statements inside a loop

Question

Errors in TypeScript are being brought up by using if-else statements inside a loop

I am currently working on a function to retrieve referral codes from users. The user inputs a code, which is then checked against the database to see if it exists or not

If the code provided matches the current user's code, it should not be accepted as self-referrals are not allowed
The code should match one of the codes stored in the database

However, I am facing an issue where even if the code exists in the database, the system fails to find a match. It works correctly when the referral code matches the current user's code and correctly points out that self-referrals are not permitted.

But in cases where the referral code matches another user's code, indicating a successful referral, the system still shows no match.

I need help in fixing this error

export const getID = functions.https.onCall(async(data, context) => {
  const db = admin.firestore();
  const usersSnapshot = await db.collection("user").get();
  const allUIDs = usersSnapshot.docs.map(doc => doc.data().userID);

  const userID = context.auth.uid;
  const providedID = "cNx7IuY6rZlR9mYSfb1hY7ROFY2";


 //db.collection("user").doc(providedID).collection("referrals").doc(userID);

  await check();

  function check() {
    let result;
    allUIDs.forEach(idFromDb => {
      if (providedID === idFromDb && (idFromDb === userID)) {
        result = "ownmatch";
      } else if (providedID === idFromDb && (idFromDb !== userID)) {
        result = "match";
      } else {
        result = "nomatch";
      }
    });
    return result;
  }

  if (check() === "match") {
    return {
      message: `Match Found`,
    };
  } else if (check() === "ownmatch") {
    return {
      message: `Sorry, you can't use your own invite code`,
    };
  } else {
    return {
      message: `No User with that ID`
    };
  }
});

javascript typescript

Answer 1

Answer №1

(This code snippet is not an answer, but rather a simple refactoring suggestion.)

Here is an overview of what your current code is doing (roughly, as it wasn't tested):

const resultMsgs = {
  nomatch:  'No User With That ID',
  ownmatch: 'Sorry, you can\'t use your own invite code',
  match:    'Match Found',
}

function check(uids, providedId, userId) {
  let result

  uids.forEach(idFromDb => {
    if (providedId !== idFromDb) {
      result = 'nomatch'
      return
    }

    if (userID === idFromDb) {
      result = 'ownmatch'
      return
    }

    result = 'match'
  })

  return result
}

export const getID = functions
  .https
  .onCall(async (data, context) => {
    const userId     = context.auth.uid
    const providedId = 'cNx7IuY6rZlR9mYSfb1hY7ROFY2'

    const db   = admin.firestore()
    const user = await db.collection('user').get()
    const uids = user.docs.map(doc => doc.data().userId)

    const checkResult = check(uids, providedId, userId)
    return { message: resultMsgs[checkResult] }
  })

(I have removed the seemingly unnecessary database collection operation from the code.)

Your forEach loop iterates over all values in the uids array, but the result variable will only store the value from the last comparison. This may be correct, but:

If you are searching for any match, this approach may not be suitable.
If you are looking for all matches, then the current logic may not work as expected.
If you intend to match the last UUID, the current implementation achieves that, albeit in a somewhat unconventional manner.

Hence:

If you seek to find any matches, consider using an appropriate any function.
If you aim to identify all matches, explore utilizing an all function instead.
If your goal is to find the first match, a simpler approach would be to check the first element directly.
If you want to perform comparisons on the complete set of values, you might need to use map instead of forEach, and handle each comparison outcome accordingly based on your requirements.

In any case, I recommend breaking down your code into smaller, more organized chunks. This will enhance its readability and maintainability, making it easier to troubleshoot and modify when needed.

Answer 2

(This code snippet is not an answer, but rather a simple refactoring suggestion.)

Here is an overview of what your current code is doing (roughly, as it wasn't tested):

const resultMsgs = {
  nomatch:  'No User With That ID',
  ownmatch: 'Sorry, you can\'t use your own invite code',
  match:    'Match Found',
}

function check(uids, providedId, userId) {
  let result

  uids.forEach(idFromDb => {
    if (providedId !== idFromDb) {
      result = 'nomatch'
      return
    }

    if (userID === idFromDb) {
      result = 'ownmatch'
      return
    }

    result = 'match'
  })

  return result
}

export const getID = functions
  .https
  .onCall(async (data, context) => {
    const userId     = context.auth.uid
    const providedId = 'cNx7IuY6rZlR9mYSfb1hY7ROFY2'

    const db   = admin.firestore()
    const user = await db.collection('user').get()
    const uids = user.docs.map(doc => doc.data().userId)

    const checkResult = check(uids, providedId, userId)
    return { message: resultMsgs[checkResult] }
  })

(I have removed the seemingly unnecessary database collection operation from the code.)

Your forEach loop iterates over all values in the uids array, but the result variable will only store the value from the last comparison. This may be correct, but:

If you are searching for any match, this approach may not be suitable.
If you are looking for all matches, then the current logic may not work as expected.
If you intend to match the last UUID, the current implementation achieves that, albeit in a somewhat unconventional manner.

Hence:

If you seek to find any matches, consider using an appropriate any function.
If you aim to identify all matches, explore utilizing an all function instead.
If your goal is to find the first match, a simpler approach would be to check the first element directly.
If you want to perform comparisons on the complete set of values, you might need to use map instead of forEach, and handle each comparison outcome accordingly based on your requirements.

In any case, I recommend breaking down your code into smaller, more organized chunks. This will enhance its readability and maintainability, making it easier to troubleshoot and modify when needed.

Errors in TypeScript are being brought up by using if-else statements inside a loop

Answer №1

Similar questions

Customizing CoreUI column names in Vue

Is it possible to execute a function within an HTML page simply by clicking on it?

I successfully converted a d3 chart to a base64 image format and now I am looking to share it on Facebook using either client-side JavaScript or Angular

Google App Engine does not properly interpret PHP code when making AJAX requests

Front-end procedural logic for increasing identification values

Enforcing TypeScript restrictions on method chaining during object creation

Experiencing issues with overflowing columns in JQuery Datatables

Saving the previous component's DOM in a React application

Troubleshooting ECONNREFUSED in NextJS API: App successfully runs in both deploy and development mode, but encounters issues when next build is executed

Unable to maintain checkbox state after page reload in React

When using Vue with Vuetify, be aware that object literals can only specify known properties. In this case, the type 'vuetify' does not exist in the ComponentOptions of Vue with DefaultData

Variable unique to the specific function in universal function

Difficulty with replacing colors in an image on certain devices when using HTML5 Canvas

Seeking specific parameter in a JSON array using JavaScript: A guide

I'm encountering difficulties in automatically populating the category field from an API

Click on an Object within a modal window using JavaScript in Internet Explorer 8

Utilize range slider to refine dataset

I'm struggling with developing react applications due to problems with canvas elements

Contrasting bracket notation property access with Pick utility in TypeScript

Understanding how to monitor a Boolean value that fluctuates in real-time within a three.js