Is there a way to optimize two methods that share similar logic but differ only in the operators they utilize?

Question

Is there a way to optimize two methods that share similar logic but differ only in the operators they utilize?

  validateToken(type: TOKEN_TYPES, symbol: string, shouldMatch: boolean) {
    let isTrue = false;
    
    if (shouldMatch) {
      if (
        this.tokenizer.getCurrentToken() === symbol &&
        this.tokenizer.tokenType() === type
      ) {
        isTrue = true;
      }
    } else {
      if (
        this.tokenizer.tokenType() !== type ||
        this.tokenizer.getCurrentToken() !== symbol
      ) {
        isTrue = true;
      }
    }

    return isTrue;
  }

By combining the functionality of the assertToken and assertNotToken methods into a single function called validateToken, we have achieved code consolidation and reusability.

javascript typescript refactoring

Answer 1

Answer №1

If you want to make a modification, you can update the second one like this:

assertNotToken(type: TOKEN_TYPES, symbol: string) {
    return !assertToken(type, string);
}

Alternatively, if you prefer not to have two separate functions, you can simply remove the assertNotToken function entirely and just negate assertToken(type, string) whenever needed.

Answer 2

If you want to make a modification, you can update the second one like this:

assertNotToken(type: TOKEN_TYPES, symbol: string) {
    return !assertToken(type, string);
}

Alternatively, if you prefer not to have two separate functions, you can simply remove the assertNotToken function entirely and just negate assertToken(type, string) whenever needed.

Answer 3

Answer №2

The comparison inside the initial function's `if` statement is essentially the inverse of that found in the second function (De Morgan's laws). To address this, consider introducing a third parameter to specify the type of assertion, allowing for the return of either `isTrue` or `!isTrue`.

checkTokenValidity(type: TOKEN_TYPES, symbol: string, isAssertion: boolean) {
  let isTrue = this.tokenizer.getCurrentToken() === symbol 
                && this.tokenizer.tokenType() === type;

  return isAssertion ? isTrue : !isTrue;
}

Answer 4

The comparison inside the initial function's `if` statement is essentially the inverse of that found in the second function (De Morgan's laws). To address this, consider introducing a third parameter to specify the type of assertion, allowing for the return of either `isTrue` or `!isTrue`.

checkTokenValidity(type: TOKEN_TYPES, symbol: string, isAssertion: boolean) {
  let isTrue = this.tokenizer.getCurrentToken() === symbol 
                && this.tokenizer.tokenType() === type;

  return isAssertion ? isTrue : !isTrue;
}

Is there a way to optimize two methods that share similar logic but differ only in the operators they utilize?

Answer №1

Answer №2

Similar questions

Angular 2 Beta Faces Issues with Loading Dynamic Routes

Validate if the Jquery AJAX response contains any data

What is the best way to call a JavaScript function that is embedded within a string?

Create static HTML files using an Express server

Modifying the data of an HTML form using Javascript, encrypting the information, and transferring it to PHP

Adjust the size of an element using the jQuery library's knob.js

Using AJAX to manipulate the document structure and execute a function

Utilizing Angular's ng-model directive in combination with the required

Encountering an 'undefined' result while attempting to retrieve context from provider in TypeScript/React

Is there a way to automatically hide a div based on a checkbox value when the page loads?

What is the process for acquiring a comprehensive catalog of Node.js modules?

The error message "ReferenceError: obj is not defined using webcomponents & polymer" indicates that the object

Setting default zoom level for Google Map in HTML

Tips for resolving the error "React import attempt":

The method for retrieving and entering a user's phone number into a text field upon their visit

Troubining AJAX for Generating a New Template: Addressing Missing Template Error

Implementing custom click event for selecting checkboxes in Material-UI table rows

Tips for ensuring the "keep-alive" functionality of a component stays active when using router-view in Vue 3

How to extract keys from an object using jQuery

Error: Property '' is not found in type 'Object'. Observable subscribe