Ways to resolve sonar problem "Ensure this function is updated or refactored to avoid duplicating the implementation on line xxx"

Question

Ways to resolve sonar problem "Ensure this function is updated or refactored to avoid duplicating the implementation on line xxx"

SonarQube has detected duplicate functions in specific lines:

beneficiaires.forEach(beneficiaire => {
() => {

Below are the identified functions:

affectPercentageToBeneficiares(beneficiaires: BeneficiaryData[], sum: number) {
    let numberOfBeneficiaresWithEmptyPrecentage = this.getBeneficiaresWithEmptyPercentageNumber(beneficiaires);
    let valueToAffecte = (100.02 - sum) / numberOfBeneficiaresWithEmptyPrecentage;
    beneficiaires.forEach(beneficiaire => {
        if (beneficiaire.percentage == "") {
            valueToAffecte = Math.round(valueToAffecte * 100) / 100;
            beneficiaire.percentage = "" + valueToAffecte;
        }
    })
}

affectPercentageToBeneficiaresInZeroCase(beneficiaires: BeneficiaryData[]) {
    let numberOfBeneficiaresWithEmptyPrecentage = this.getBeneficiaresWithEmptyPercentageNumber(beneficiaires);
    let valueToAffecte = (100) / numberOfBeneficiaresWithEmptyPrecentage;
    beneficiaires.forEach(beneficiaire => {
        if (beneficiaire.percentage == "") {
            valueToAffecte = Math.round(valueToAffecte * 100) / 100;
            beneficiaire.percentage = "" + valueToAffecte;
        }
    });
}

this.userProfilService.updateUser(this.UpdatedUser)
    .subscribe(
        () => {
            this.toastr.success('User has been updated successfully', null, {
                enableHtml: true,
            });
        },
        (err) => {
            this.toastr.error('erreur dans la modification utilisateur', null, {
                enableHtml: true,
            });
        }
    );

this.userProfilService.addUser(this.User)
    .subscribe(
        () => {
            this.toastr.success('User has been created', null, {
                enableHtml: true,
            });
        },
        (err) => {
            throw err;
        }
    );

Is there a way to resolve the issue with the duplicate functions without merging them?

Thank you

angular typescript sonarqube

Answer 1

Answer №1

To avoid merging the functions, just ensure that you have only one instance of the function being used in both places (the forEach callback). Extract the beneficiary update logic into its own separate function or method and invoke it from both locations:

// Define a standalone function outside the class
function updateBeneficiaries(beneficiaries, valueToAffect) {
    beneficiaries.forEach(beneficiary => {
        if (beneficiary.percentage == "") {
            valueToAffect = Math.round(valueToAffect * 100) / 100;
            beneficiary.percentage = "" + valueToAffect;
        }
    });
}

// Inside the class methods
affectPercentageToBeneficiaries(beneficiaries: BeneficiaryData[], sum: number) {
    let numberOfBeneficiariesWithEmptyPercentage = this.getBeneficiariesWithEmptyPercentageNumber(beneficiaries);
    let valueToAffect = (100.02 - sum) / numberOfBeneficiariesWithEmptyPercentage;
    updateBeneficiaries(beneficiaries, valueToAffect);
}

affectPercentageToBeneficiariesInZeroCase(beneficiaries: BeneficiaryData[]) {
    let numberOfBeneficiariesWithEmptyPercentage = this.getBeneficiariesWithEmptyPercentageNumber(beneficiaries);
    let valueToAffect = 100 / numberOfBeneficiariesWithEmptyPercentage;
    updateBeneficiaries(beneficiaries, valueToAffect);
}

(Alternatively, you can turn it into a class method, but since it doesn't rely on any class properties, consider making it private static.)

Answer 2

To avoid merging the functions, just ensure that you have only one instance of the function being used in both places (the forEach callback). Extract the beneficiary update logic into its own separate function or method and invoke it from both locations:

// Define a standalone function outside the class
function updateBeneficiaries(beneficiaries, valueToAffect) {
    beneficiaries.forEach(beneficiary => {
        if (beneficiary.percentage == "") {
            valueToAffect = Math.round(valueToAffect * 100) / 100;
            beneficiary.percentage = "" + valueToAffect;
        }
    });
}

// Inside the class methods
affectPercentageToBeneficiaries(beneficiaries: BeneficiaryData[], sum: number) {
    let numberOfBeneficiariesWithEmptyPercentage = this.getBeneficiariesWithEmptyPercentageNumber(beneficiaries);
    let valueToAffect = (100.02 - sum) / numberOfBeneficiariesWithEmptyPercentage;
    updateBeneficiaries(beneficiaries, valueToAffect);
}

affectPercentageToBeneficiariesInZeroCase(beneficiaries: BeneficiaryData[]) {
    let numberOfBeneficiariesWithEmptyPercentage = this.getBeneficiariesWithEmptyPercentageNumber(beneficiaries);
    let valueToAffect = 100 / numberOfBeneficiariesWithEmptyPercentage;
    updateBeneficiaries(beneficiaries, valueToAffect);
}

(Alternatively, you can turn it into a class method, but since it doesn't rely on any class properties, consider making it private static.)

Ways to resolve sonar problem "Ensure this function is updated or refactored to avoid duplicating the implementation on line xxx"

Answer №1

Similar questions

Having difficulty in converting JSON objects into key/value pairs in Angular 7

Angular 4: Conditional CSS classes causing issues with transitions

Custom Type Guard Leads to Intersection Type Outcome

Guidelines for Nestjs class-validator exception - implementing metadata information for @IsNotIn validator error handling

Tips for deciding on the appropriate CSS for an Angular 6 navbar component

What happens when two style() functions are passed into the query() function for Angular Animations?

Upon running the "npm install" command, the node_modules folder appears to be

What is the best way to obtain the variable value?

Leveraging both Angular Material UI and Tailwind CSS simultaneously

I encounter an error message stating "Cannot read property 'push' of undefined" when trying to add an item to a property within an interface

What is the best way to transfer the $event parameter from a dynamically generated function that requires the $event argument during a typical mouse click operation?

The TypeScript compiler is attempting to locate relative path modules in an incorrect directory

Error encountered while downloading file from S3 on NextJs due to network issue

Validation of decimal numbers in JavaScript without the presence of any other characters

What is the best way to insert a chart into a div using *ngIf in Angular?

Choose a specific location on a vehicle illustration within a pop-up window. The image should be partitioned into 6 separate sections

Encountering issues accessing / Error within MEAN stack application

Issue with accessing custom method in subclass in Typescript

Unlocking the Magic: A Step-by-Step Guide to Generating PDFs with

Allow only numerical values through an ion-input in Ionic 4, preventing the input of letters and special characters