What is the best way to implement a Promise Function within a For loop?

Question

What is the best way to implement a Promise Function within a For loop?

Here is a function called sendEmail:

public async sendEmail (log: LogMessage): Promise<void> {
nodemailer.createTestAccount(async () => {
      return ServiceFactory.getSystemService().getNetworkPreferences().then(async (networkPreferences) => {
....

I am looking to incorporate this function into a for loop:

for (const log of logs) {
          const timestamp = moment(log.creationDate)
          const startTime = new Date(Date.now())
          if ((timestamp.diff(startTime)) >= rule.miliSecond && category.includes(log.category)) {

            return this.sendEmail(log)
          }
        }

The issue I am facing is that I cannot remove "return this.sendEmail(log)" since the function returns a Promise. However, the loop only runs once with the first log before terminating. How can I make sure the function is executed within the loop?

typescript for-loop promise

Answer 1

Answer №1

To efficiently handle multiple promises, store them in an array and create a promise that resolves only when all the sendEmail promises have completed.

sendAll() {
    let allMails: Promise<void>[] = [];
    for (const log of logs) {
        const timestamp = moment(log.creationDate)
        const startTime = new Date(Date.now())
        if ((timestamp.diff(startTime)) >= rule.miliSecond && category.includes(log.category)) {

            allMails.push(this.sendEmail(log));
        }
    }
    return Promise.all(allMails);
}

If you prefer to execute the sendEmail functions sequentially, you can utilize async/await to pause execution until one email is sent before proceeding with the next one:

async sendAll(): Promise<void> {
    for (const log of logs) {
        const timestamp = moment(log.creationDate)
        const startTime = new Date(Date.now())
        if ((timestamp.diff(startTime)) >= rule.miliSecond && category.includes(log.category)) {

            await this.sendEmail(log);
        }
    }
}

Answer 2

To efficiently handle multiple promises, store them in an array and create a promise that resolves only when all the sendEmail promises have completed.

sendAll() {
    let allMails: Promise<void>[] = [];
    for (const log of logs) {
        const timestamp = moment(log.creationDate)
        const startTime = new Date(Date.now())
        if ((timestamp.diff(startTime)) >= rule.miliSecond && category.includes(log.category)) {

            allMails.push(this.sendEmail(log));
        }
    }
    return Promise.all(allMails);
}

If you prefer to execute the sendEmail functions sequentially, you can utilize async/await to pause execution until one email is sent before proceeding with the next one:

async sendAll(): Promise<void> {
    for (const log of logs) {
        const timestamp = moment(log.creationDate)
        const startTime = new Date(Date.now())
        if ((timestamp.diff(startTime)) >= rule.miliSecond && category.includes(log.category)) {

            await this.sendEmail(log);
        }
    }
}

What is the best way to implement a Promise Function within a For loop?

Answer №1

Similar questions

Switch up the key while iterating through a JSON object

Encountering an error when implementing a router object within a TypeScript class in a Node.js environment

A destructured object with a Typescript interface

The 'catch' property is not found within the type 'PromiseLike<void>'

Is there a mistake in the TypeScript guide for custom typography in MUI5?

Steps for specifying the required type of an Object literal in Typescript

The module for the class could not be identified during the ng build process when using the --

What is the best approach for utilizing Inheritance in Models within Angular2 with TypeScript?

Merging the functions 'plainToClass' and 'validate' into a single generic function in NodeJs

Error in TypeScript code for combined Slider and Input onChange functionality within a Material-UI component

Struggling with setting up a search bar for infinite scrolling content

Having trouble retrieving values from radio buttons in Angular 2 forms

Issue: Encounter of "Uncaught (in promise) TypeError" while implementing RiveScript chatbot in Angular

Introducing the concept of type-specific name inclusion

What is the reason for a boolean extracted from a union type showing that it is not equivalent to true?

Dependencies exclusively for NPM post-installUnique Rewrite: "N

Creating a TypeScript interface where the type of one property is based on the type of another property

Visit the map only after the promises have been fulfilled

Display the new data from an array that has been created following a subscription to Angular Firestore

Is there a way for me to retrieve the bodyHeight attribute of ag-grid using public variables or data?